Update s-badge.php for additional switch parms #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch cases do not accurately reflect the parameter values sent via the shortcode generated (and example provided) of [s2Member-Security-Badge v="1" /] in the s2Member>>General Options>>s2Member Security Badge accordian for the 2nd and 3rd variations. Notice this generated shortcode and example does not have v="v1", but rather it is implied that you should use v="2" or v="3". This causes the badges generated via http://www.s2member.com/s-badges/s-details.php to be distorted when displayed because the width and height attributes are not correct (because default: is used to generate the HTML).
|
Examples of distorted badges: |
jaswrks
pushed a commit
that referenced
this pull request
Feb 4, 2015
Update s-badge.php for additional switch parms
|
Thanks so much! I'll make sure this goes out with the next release. |
|
Next Release Changelog:
|
|
Sweet! Glad to be part of the best WP plugin in the history of ever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch cases do not accurately reflect the parameter values sent via the shortcode generated (and example provided) of [s2Member-Security-Badge v="1" /] in the s2Member>>General Options>>s2Member Security Badge accordian for the 2nd and 3rd variations.
Notice this generated shortcode and example does not have v="v1", but rather it is implied that you should use v="2" or v="3".
This causes the badges generated via http://www.s2member.com/s-badges/s-details.php to be distorted when displayed because the width and height attributes are not correct (because default: is used to generate the HTML).