New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Create a plugin option that lets you define the scenarios where the widget should be loaded. #12

Closed
jaswrks opened this Issue Sep 24, 2016 · 17 comments

Comments

Projects
None yet
3 participants

jaswrks pushed a commit that referenced this issue Sep 24, 2016

jaswsinc

@jaswrks jaswrks referenced this issue Sep 24, 2016

Merged

PR: feature/12 #16

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Sep 24, 2016

A filter = 1 story point.

jaswrks pushed a commit that referenced this issue Sep 24, 2016

jaswsinc
@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Sep 24, 2016

  • New Filter: add_filter('woocommerce_intercom_js_snippet_enable', '__return_false'); to disable the JS snippet selectively.

@jaswrks jaswrks closed this Sep 24, 2016

@jaswrks jaswrks reopened this Sep 24, 2016

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Sep 24, 2016

Reopening. This is a partial completion.

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Sep 26, 2016

Reopening. This is a partial completion.

Still 1 story point here?

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Oct 31, 2016

Looking at this again I think a filter is all that's needed here and we have already done that. Do you agree that a filter is adequate for this or do you have something else in mind?

@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Oct 31, 2016

Hmm, I was thinking this would look like a list of checkboxes where you could enable/disable the widget on certain pages. For example:

  • Home Page
  • Single Posts
  • Single Pages
  • Category Archive Views
  • Tag Archive Views
  • Custom Post Types [lists any CPTs that have been registered]

Thinking about this a bit more, it might be useful to even have a URI Exclusions Panel where a site owner could define a list of exclusions.

My thinking here is that a site owner might not want the Intercom Widget to appear on every single page of their site. For example, they may have a WooCommerce Store section of their site, where the Intercom widget is applicable. But the rest of their site — the Home Page, the Blog (and all associated Posts and post archive views) — they might not want the Intercom widget to appear.

@raamdev raamdev modified the milestone: Next Release Oct 31, 2016

jaswrks pushed a commit that referenced this issue Nov 19, 2016

jaswsinc

@jaswrks jaswrks referenced this issue Nov 19, 2016

Merged

PR: feature/12 #26

jaswrks pushed a commit that referenced this issue Nov 19, 2016

jaswsinc
- **New Feature:** Adding support for URI Inclusion patterns. See [Is…
…sue #12](#12).

- **New Feature:** Adding support for URI Exclusion patterns. See [Issue #12](#12).
@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Nov 19, 2016

Next Release Changelog:

  • New Feature: Adding support for URI Inclusion patterns. See Issue #12.
  • New Feature: Adding support for URI Exclusion patterns. See Issue #12.

2016-11-19_08-41-03

jaswrks pushed a commit that referenced this issue Nov 19, 2016

jaswsinc

jaswrks pushed a commit that referenced this issue Nov 19, 2016

@raamdev raamdev added the enhancement label Nov 21, 2016

@renzms

This comment has been minimized.

Copy link

renzms commented Nov 28, 2016

@raamdev

Feature confirmed as working.

Tested using:

  • WP Sharks Core Version 161026.47592
  • WooCommerce Intercom Pro Version 161124.6961-RC
  • WooCommerce Version 2.6.8

Tested Inclusions/Exclusions:

  • using direct file paths
  • using WRegx and and Advanced WRegx from samples in KBA
  • using combinations of Inclusions and/or Exclusions, (if the Exclusion URI somehow overlaps with the Inclusion URI using WRegx, the Exclusion pattern is the one that is followed)
  • using multi-line Inclusion/Exclusions

May I suggest to include in the documentation or article that ^/$, means homepage, as it might be helpful for users. Also, our other plugins included a note like the following:

Note: please remember that your entries here should be formatted as a line-delimited list; e.g., one exclusion pattern per line.

That might be helpful also for users to know for the Inclusion/Exclusions in case they want to be very specific about the pages.

No bugs here 👍

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Nov 29, 2016

Note: please remember that your entries here should be formatted as a line-delimited list; e.g., one exclusion pattern per line.

I agree we should add a note about this.

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Dec 3, 2016

Noted added.

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Dec 3, 2016

Additional changelog entry:

  • New Feature: It is now possible to configure the Intercom Messenger icon display settings so that it's only shown to logged-in users, only to logged-out users, or to everyone (default behavior). See: Dashboard → WooCommerce → Intercom → Messenger Display Options.

2016-12-03_06-49-36

jaswrks pushed a commit that referenced this issue Dec 3, 2016

jaswsinc
@renzms

This comment has been minimized.

Copy link

renzms commented Dec 5, 2016

@jaswsinc

The Logged-In User Status feature is currently not working for me in the latest RC test.

Regardless of whether the user is logged-in/logged-out and the settings chosen for the feature, the Intercom messenger appears on the front end.

Show only to logged-out Users is showing to logged-in User

screen shot 2016-12-06 at 12 33 16 am
screen shot 2016-12-06 at 12 33 38 am


Show only to logged-in Users is showing to logged-out User

screen shot 2016-12-06 at 12 32 54 am
screen shot 2016-12-06 at 12 33 01 am

Positive note, the URI Exclusion/Inclusion is still working fine 👍

@renzms

This comment has been minimized.

Copy link

renzms commented Dec 5, 2016

@raamdev @jaswsinc

Links to KBAs redirect properly to https://wpsharks.com/kb/[product] or https://wpsharks.com/kb-articles/.

The link to Intercom Acquire goes first to https://wpsharks.com/r/intercom-acquire and then https://www.intercom.com/live-chat, is this correct?

@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Dec 5, 2016

The link to Intercom Acquire goes first to https://wpsharks.com/r/intercom-acquire and then https://www.intercom.com/live-chat, is this correct?

That looks right to me, yes.

jaswrks pushed a commit that referenced this issue Dec 5, 2016

jaswsinc
@jaswrks

This comment has been minimized.

Copy link

jaswrks commented Dec 5, 2016

@raamdev @renzms The bug with logged-in/out has been fixed now. Thanks for catching that!

@renzms

This comment has been minimized.

Copy link

renzms commented Dec 8, 2016

The bug with logged-in/out has been fixed now.

@jaswsinc @raamdev

Fix confirmed as working for all options of Logged-In User Status

All good here on my end 👍

raamdev added a commit to wpsharks/woocommerce-intercom that referenced this issue Dec 10, 2016

Phing release of v161209.85885 with the following changes:
- **Bug Fix:** Call to undefined method `WC_Order::get_currency()` should be `get_order_currency()`. Reported by @raamdev in [this GitHub issue](wpsharks/woocommerce-intercom-pro#4).
- **Bug Fix:** Before a new Event is generated to track a user's Order or Subscription status on the Intercom side, a new API call is now made to ensure that a matching User does in fact exist on the Intercom side before an Event is created. This corrects a problem reported in the previous release that resulted in an error during checkout: `User Not Found`. See [Issue #6](wpsharks/woocommerce-intercom-pro#6 (comment))
- **Bug Fix:** In the Event API calls, `amount` must be given in **cents** (i.e., total x 100) for proper calculation on the Intercom side. Closes [this GitHub issue](wpsharks/woocommerce-intercom-pro#17).
- **New Feature:** It is now possible to configure the Intercom Messenger icon display settings so that it's only shown to logged-in users, only to logged-out users, or to everyone (default behavior). See: **Dashboard → WooCommerce → Intercom → Messenger Display Options**.
- **New Feature:** Adding support for URI Inclusion patterns. See [Issue #12](wpsharks/woocommerce-intercom-pro#12).
- **New Feature:** Adding support for URI Exclusion patterns. See [Issue #12](wpsharks/woocommerce-intercom-pro#12).
- **New People Attribute:** This release adds a new People Attribute by the name of `wp_user_id`, giving support reps. the ability to track WP User IDs in Intercom.
- **New Filter:** A new filter has been exposed: `js_snippet_attrs`. This allows a developer to add their own custom attributes; above and beyond what is already defined by WooCommerce Intercom Pro itself.
- **New Filter:** `add_filter('woocommerce_intercom_js_snippet_enable', '__return_false');` to disable the JS snippet selectively.
- **Enhancement:** Standardizing Event names sent to Intercom. New format: `order-[status]`. See [Issue #19](wpsharks/woocommerce-intercom-pro#19).
- **Enhancement:** Adding `wp_home_url` and `wp_network_home_url` fields to JS Snippet to make it easier for support representatives to identify the origin of a customer request; e.g., whenever a single Intercom account is being used to support more then one WordPress installation, or multiple child sites/domains in a Multisite Network. See [Issue #22](wpsharks/woocommerce-intercom-pro#22).
- **Intercom `user_id`:** This release changes the way an Intercom `user_id` is generated. Instead of just the WP User ID, the Intercom `user_id` is now formulated in a way that allows a single Intercom account to be used for multiple installations of WordPress. The `user_id` sent to Intercom is now made up of two parts. 1. A hash of the current WordPress `home_url()` (normalized). 2. The current user's WordPress ID (or, in the case of guest checkout, an `e-`, followed by a hash of the user's email address). The final `user_id` becomes: `[location hash].[user ID]`; e.g., `3610a686.123`, `3610a686.e-9943c993` (guest).
- **Compatibility:** Adding support and compatibility with WPML's `ICL_LANGUAGE_CODE` so the Intercom messenger will always be displayed in an appropriate language.
- **Compatibility:** This release adds compatibility with WooCommerce Subscriptions. See [Issue #1](wpsharks/woocommerce-intercom-pro#1).
- **Compatibility:** This release adds support for all WooCommerce Order and/or Subscription status changes, including those added by WooCommerce extensions such as the WooCommerce Give Order extension. See [Issue #1](wpsharks/woocommerce-intercom-pro#1).
- **Compatibility:** Removing API Key setting for Intercom in favor of a Personal Access Token. There is now a configuration field under: **WP Dashboard → WooCommerce → Intercom** settings where you can supply a Personal Access Token for API calls to Intercom. Use the instructions provided in this area to generate and fill-in your Personal Access Token. See [Issue #20](wpsharks/woocommerce-intercom-pro#20).
- **Compatibility:** Adding support for guest checkout events that track a customer by email address instead of by user ID. Closes [this GitHub issue](wpsharks/woocommerce-intercom-pro#6).
- **Compatibility:** Updating `composer.json` to specify that we will use the Intercom SDK v3.x (but not 4.x) until a full review of a new major release has been completed.
- **Cleanup:** Moving JS snippet into a template file w/ replacement code. Closes [this GitHub issue](wpsharks/woocommerce-intercom-pro#8).
@raamdev

This comment has been minimized.

Copy link
Contributor

raamdev commented Dec 10, 2016

WooCommerce Intercom Pro v161209.85885 has been released and includes changes from this GitHub Issue. See the changelog for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#12).

@raamdev raamdev closed this Dec 10, 2016

@wpsharks wpsharks locked and limited conversation to collaborators Dec 10, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.