New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PHP Compatibility parsed output to include warnings #17

Merged
merged 8 commits into from Feb 16, 2019

Conversation

Projects
None yet
4 participants
@valendesigns
Copy link
Member

valendesigns commented Dec 5, 2018

No description provided.

@valendesigns valendesigns requested a review from rheinardkorf Dec 7, 2018

@jrfnl

This comment has been minimized.

Copy link

jrfnl commented Jan 9, 2019

Saw this ticket mentioned in Slack and had a quick look. I thought Tide had been updated to use PHPCompatibility 9.0.0 ?
If so, that's probably why the tests are failing as they still refer to the old PHPCompatibility error codes.

Edit: if Tide hasn't upgraded to PHPCompatibility 9.0.0/PHPCompatibilityWP 2.0.0 yet, that really should happen before the release as otherwise people may start whitelisting code using the old/outdated error codes which would just cause confusion for the future.

valendesigns added some commits Feb 16, 2019

@wptide wptide deleted a comment from coveralls Feb 16, 2019

valendesigns added some commits Feb 16, 2019

@valendesigns valendesigns merged commit 60d75b0 into master Feb 16, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 97.565%
Details

@valendesigns valendesigns deleted the phpcompat-schema branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment