Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend API with PHP 'incompatible_versions' (Closes: wptide/wptide#184) #19

Conversation

@ottok
Copy link
Contributor

commented Jun 20, 2019

@ottok ottok force-pushed the Seravo:feature/extend-api-incompatible-php-versions branch from c685949 to 9c2d779 Jun 20, 2019

@ottok

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

The code is fine. Travis-CI is not failing due to oode issues.

Pull request CI fails as a $COVERALLS_TOKEN token is missing from Travis-CI

$ goveralls -coverprofile=overalls.coverprofile -service=travis-ci -repotoken $COVERALLS_TOKEN
flag needs an argument: -repotoken
The command "goveralls -coverprofile=overalls.coverprofile -service=travis-ci -repotoken $COVERALLS_TOKEN" exited with 2.

@ottok

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@ottok

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

I am trying to run the test suite but I don't get it how you have intended that the build artifacts directory structure is supposed to be and I can't get the test to pick up the dependencies from the correct directories.

Commands and output inside my development Golan container:

root@b2e6fa89e4c4:/tmp/build# make deps
Installing dependencies ...
[WARN]	The name listed in the config file (github.com/wptide/pkg) does not match the current location (.)
[INFO]	Downloading dependencies. Please wait...
[INFO]	--> Found desired version locally cloud.google.com/go 0fd7230b2a7505833d5f69b75cbd6c9582401479!
...
[INFO]	Setting references.
[INFO]	--> Setting version for github.com/mongodb/mongo-go-driver to de03a35e8661ae6df623f41ec8f616ffd8ef6131.
...
[INFO]	Exporting resolved dependencies...
[INFO]	--> Exporting github.com/aws/aws-sdk-go
[INFO]	--> Exporting github.com/googleapis/gax-go
...
[INFO]	--> Exporting cloud.google.com/go
[INFO]	Replacing existing vendor dependencies

root@b2e6fa89e4c4:/tmp/build# go test -cover tide
../src/tide/item.go:3:8: cannot find package "reflect" in any of:
	/tmp/src/vendor/reflect (vendor tree)
	/tmp/src/reflect (from $GOROOT)
	/root/go/src/reflect (from $GOPATH)
root@b2e6fa89e4c4:/tmp/build# go test -cover tide/api
../src/tide/api/api.go:4:2: cannot find package "bytes" in any of:
	/tmp/src/vendor/bytes (vendor tree)
	/tmp/src/bytes (from $GOROOT)
	/root/go/src/bytes (from $GOPATH)
../src/tide/api/api.go:5:2: cannot find package "encoding/json" in any of:
	/tmp/src/vendor/encoding/json (vendor tree)
	/tmp/src/encoding/json (from $GOROOT)
	/root/go/src/encoding/json (from $GOPATH)
../src/tide/api/api.go:6:2: cannot find package "errors" in any of:
	/tmp/src/vendor/errors (vendor tree)
	/tmp/src/errors (from $GOROOT)
	/root/go/src/errors (from $GOPATH)
../src/tide/api/api.go:7:2: cannot find package "fmt" in any of:
	/tmp/src/vendor/fmt (vendor tree)
	/tmp/src/fmt (from $GOROOT)
	/root/go/src/fmt (from $GOPATH)
../src/tide/api/api.go:8:2: cannot find package "github.com/wptide/pkg/tide" in any of:
	/tmp/src/vendor/github.com/wptide/pkg/tide (vendor tree)
	/tmp/src/github.com/wptide/pkg/tide (from $GOROOT)
	/root/go/src/github.com/wptide/pkg/tide (from $GOPATH)
../src/tide/api/api.go:9:2: cannot find package "io/ioutil" in any of:
	/tmp/src/vendor/io/ioutil (vendor tree)
	/tmp/src/io/ioutil (from $GOROOT)
	/root/go/src/io/ioutil (from $GOPATH)
../src/tide/api/api.go:10:2: cannot find package "net/http" in any of:
	/tmp/src/vendor/net/http (vendor tree)
	/tmp/src/net/http (from $GOROOT)
	/root/go/src/net/http (from $GOPATH)
../src/tide/api/api.go:11:2: cannot find package "net/url" in any of:
	/tmp/src/vendor/net/url (vendor tree)
	/tmp/src/net/url (from $GOROOT)
	/root/go/src/net/url (from $GOPATH)
root@b2e6fa89e4c4:/tmp/build# 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.