New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate audits #139

Open
jeffpaul opened this Issue Jun 26, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@jeffpaul
Member

jeffpaul commented Jun 26, 2018

Description

There appears to be an issue with the Firestore integration locks as we're seeing instances of duplicate audits of the same plugin checksum (in some cases more than two audits are run), so we'll want to review the locking to ensure its catching all edge cases to eliminate this waste of resources. Some examples...
Reply Comment to Email:
https://wptide.org/api/tide/v1/audit/51026
https://wptide.org/api/tide/v1/audit/51027
Feedburner Right Now Stats:
https://wptide.org/api/tide/v1/audit/51020
https://wptide.org/api/tide/v1/audit/51021
https://wptide.org/api/tide/v1/audit/51022

Steps to Reproduce

  1. Query for plugin results via checksum
  2. See multiple results
  3. 💩

Expected behavior: [What you expect to happen]
Only a single audit results for each plugin checksum

Actual behavior: [What actually happens]
Multiple cases of duplicate (or more) audit results for a single plugin checksum

Reproduces how often: [What percentage of the time does it reproduce?]
I haven't run a full population analysis of audit results, but its significant enough to be a concern.

@jeffpaul

This comment has been minimized.

Member

jeffpaul commented Aug 29, 2018

Per bugscrub today, we're keeping this in the 1.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment