Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the JSON output to inclide 'incompatible_versions' #184

Closed
ottok opened this issue Jun 20, 2019 · 4 comments · Fixed by wptide/pkg#20

Comments

@ottok
Copy link

commented Jun 20, 2019

Current Behavior

Currently the JSON output includes this:

        "compatible_versions": [
          "5.6",
          "7.0",
          "7.1",
          "7.2"
         ],

There is however no indication of what versions was tested or what versions the plugin/theme is NOT compatible with.
]

Possible Solution

Extend the JSON output to have a 'incompatible_versions' field. Then the output would be something like:

        "compatible_versions": [
          "5.6",
          "7.0",
          "7.1",
          "7.2"
         ],
        "incompatible_versions": [
          "5.2",
          "5.3"
         ],

As a side note please start testing for PHP 7.3 compatibility as well, and for PHP 7.4 as soon as the ruleset is out.

@ottok

This comment has been minimized.

Copy link
Author

commented Jun 20, 2019

The API seems to be generated via https://github.com/wptide/pkg/blob/master/tide/tide.go. I tried to figure out how to fix this myself but the code layout has so many abstractions that I can't follow it.

@ottok

This comment has been minimized.

Copy link
Author

commented Jun 20, 2019

I scanned through wp-tide-api and it does not have the string compatible_versions anywhere, so I suspect no changes is needed to that plugin.

Somebody who has the full pipeline set up on their computer should test my patch in wptide/pkg#19 if it actually works.

@jeffpaul jeffpaul added this to the 1.0.0 milestone Jun 20, 2019

@jeffpaul

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

@ottok welcome to Tide and thanks for the feedback! I agree that makes sense to include the incompatible versions that we've tested as well, thanks for calling this out and working towards a solution.

@jeffpaul

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@ottok note the recently merged PR, please confirm that it appears updated properly now... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.