Ipol breaking due to changes in scipy 0.18.0 #86

Closed
kmuehlbauer opened this Issue Jul 26, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@kmuehlbauer
Member

kmuehlbauer commented Jul 26, 2016

When using scipy 0.18.0 the ipol notebook breaks while handling nan-data. Needs reworking. Pinned scipy to 0.17.1 within travis in #84.

@kmuehlbauer kmuehlbauer added the Bug label Jul 26, 2016

@kmuehlbauer

This comment has been minimized.

Show comment
Hide comment
Member

kmuehlbauer commented Jul 26, 2016

See this travis-log.

@kmuehlbauer

This comment has been minimized.

Show comment
Hide comment
@kmuehlbauer

kmuehlbauer Aug 23, 2016

Member

@heistermann Did you had the chance to look into this? Any ideas?

Member

kmuehlbauer commented Aug 23, 2016

@heistermann Did you had the chance to look into this? Any ideas?

@heistermann

This comment has been minimized.

Show comment
Hide comment
@heistermann

heistermann Aug 24, 2016

Collaborator

@kmuehlbauer: Not yet, but asap. Thanks for pointing this out.

Collaborator

heistermann commented Aug 24, 2016

@kmuehlbauer: Not yet, but asap. Thanks for pointing this out.

@heistermann heistermann self-assigned this Aug 24, 2016

@kmuehlbauer kmuehlbauer referenced this issue Aug 24, 2016

Closed

Finalize Release 0.9.0 #83

11 of 11 tasks complete
@heistermann

This comment has been minimized.

Show comment
Hide comment
@heistermann

heistermann Aug 24, 2016

Collaborator

Apparently related to scipy/scipy#6515

Problem occurs in case the parameter nnearest is larger than the number of source points. I'll try to find a more generic solution.

Collaborator

heistermann commented Aug 24, 2016

Apparently related to scipy/scipy#6515

Problem occurs in case the parameter nnearest is larger than the number of source points. I'll try to find a more generic solution.

@kmuehlbauer

This comment has been minimized.

Show comment
Hide comment
@kmuehlbauer

kmuehlbauer Aug 24, 2016

Member

There were some changes in ckdtree implementation, but I‘m not sure, if this is effecting this. Let‘s see what the scipy devs say.

Member

kmuehlbauer commented Aug 24, 2016

There were some changes in ckdtree implementation, but I‘m not sure, if this is effecting this. Let‘s see what the scipy devs say.

@heistermann

This comment has been minimized.

Show comment
Hide comment
@heistermann

heistermann Aug 25, 2016

Collaborator

Addressed by Pull Request #95.

Collaborator

heistermann commented Aug 25, 2016

Addressed by Pull Request #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment