New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default parameters for WX data format #119

Merged
merged 5 commits into from Nov 10, 2016

Conversation

Projects
None yet
4 participants
@franklinvv
Contributor

franklinvv commented Nov 8, 2016

The DWD also supplies WX files with dimensions of 1100x900. When compared to the RX grid, the WX grid is displaced 80km towards the east, and expanded 100km northwards and southwards.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 8, 2016

Coverage Status

Coverage increased (+0.004%) to 82.128% when pulling cd140ad on franklinvv:master into 50fc912 on wradlib:master.

coveralls commented Nov 8, 2016

Coverage Status

Coverage increased (+0.004%) to 82.128% when pulling cd140ad on franklinvv:master into 50fc912 on wradlib:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 8, 2016

Coverage Status

Coverage increased (+0.004%) to 82.128% when pulling cd140ad on franklinvv:master into 50fc912 on wradlib:master.

coveralls commented Nov 8, 2016

Coverage Status

Coverage increased (+0.004%) to 82.128% when pulling cd140ad on franklinvv:master into 50fc912 on wradlib:master.

@kmuehlbauer

This comment has been minimized.

Show comment
Hide comment
@kmuehlbauer

kmuehlbauer Nov 9, 2016

Member

@franklinvv This is looking good to me. I added WX to the radolan showcase notebook in franklinvv#1. We can proceed after you merged this into your master.

Next time please consider using a branch instead of 'master' for contributing.

Member

kmuehlbauer commented Nov 9, 2016

@franklinvv This is looking good to me. I added WX to the radolan showcase notebook in franklinvv#1. We can proceed after you merged this into your master.

Next time please consider using a branch instead of 'master' for contributing.

Merge pull request #1 from kmuehlbauer/wx-radolan
DOC: adding WX-fomat to radolan-showcase
@franklinvv

This comment has been minimized.

Show comment
Hide comment
@franklinvv

franklinvv Nov 9, 2016

Contributor

@kmuehlbauer My apologies, I'm not completely comfortable with the standard workflow between forks. I just merged your pull request. Do I need to do anything else now?

Contributor

franklinvv commented Nov 9, 2016

@kmuehlbauer My apologies, I'm not completely comfortable with the standard workflow between forks. I just merged your pull request. Do I need to do anything else now?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 9, 2016

Coverage Status

Coverage increased (+0.004%) to 82.128% when pulling e40535f on franklinvv:master into 50fc912 on wradlib:master.

coveralls commented Nov 9, 2016

Coverage Status

Coverage increased (+0.004%) to 82.128% when pulling e40535f on franklinvv:master into 50fc912 on wradlib:master.

@kmuehlbauer

This comment has been minimized.

Show comment
Hide comment
@kmuehlbauer

kmuehlbauer Nov 10, 2016

Member

@franklinvv ATM there is nothing left for you to do. Good work!

Regarding standard workflow: here is some information.

For a change this small (and for a project which doesn't get tons of PR's every week 😁) it seems unreasonable to create a special topic branch in the contributors fork. But this way your changes are isolated in this branch and you can commit/revert/merge to your liking. Using the master for this can get complicated, if the project master (upstream) changes frequently.

@franklinvv Thanks again for this addition. Hopefully we will see more contributions from you in the future 👍

@heistermann This ready for merge, I think.

Member

kmuehlbauer commented Nov 10, 2016

@franklinvv ATM there is nothing left for you to do. Good work!

Regarding standard workflow: here is some information.

For a change this small (and for a project which doesn't get tons of PR's every week 😁) it seems unreasonable to create a special topic branch in the contributors fork. But this way your changes are isolated in this branch and you can commit/revert/merge to your liking. Using the master for this can get complicated, if the project master (upstream) changes frequently.

@franklinvv Thanks again for this addition. Hopefully we will see more contributions from you in the future 👍

@heistermann This ready for merge, I think.

@kmuehlbauer kmuehlbauer merged commit 9950d3d into wradlib:master Nov 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 82.128%
Details

@kmuehlbauer kmuehlbauer added this to the Release 0.10.0 milestone Mar 23, 2017

kmuehlbauer added a commit that referenced this pull request Feb 28, 2018

Merge pull request #119 from franklinvv/master
Added default parameters for WX data format, added WX to RADOLAN-docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment