Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Raster handling #137

Merged
merged 23 commits into from
Mar 31, 2017
Merged

Conversation

kmuehlbauer
Copy link
Member

@kmuehlbauer kmuehlbauer commented Mar 22, 2017

This PR handles the issues outline in #135

new functions

  • georef.create_raster_dataset (data, coords, proj -> dataset)
  • georef.extract_raster_dataset (dataset -> data, coords, proj)
  • georef.set_raster_origin (flip data and coords, if necessary)
  • georef.reproject_raster_dataset (and resampling)
  • io.write_raster_dataset (write to disc)
  • util.get_raster_origin (returns upper or lower)
  • add unit-tests

deprecated functions

  • deprecate io.to_AAIGrid and to_GeoTIFF
  • deprecate io.read_raster_dataset (the magic needed in this function isn't worth the work)
  • deprecate georef.resample_raster_dataset

other fixes

  • fix zonalstats.DataSource.dump_raster to use new functionality
  • fixed io.read_safnwc (proj4/wkt-handling)
  • update notebooks/fileio/wradlib_gis_export_example.ipynb
  • update georef.read_gdal_values to read multi band data
  • fix util.find_bbox_indices to account for lower or upper origin data/coords
  • fix ipol.cart2irregular_spline to account for data/coords origin

@codecov
Copy link

codecov bot commented Mar 22, 2017

Codecov Report

Merging #137 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage    82.6%   82.69%   +0.08%     
==========================================
  Files          18       18              
  Lines        4341     4467     +126     
==========================================
+ Hits         3586     3694     +108     
- Misses        755      773      +18
Impacted Files Coverage Δ
wradlib/georef.py 90.37% <ø> (+0.03%) ⬆️
wradlib/io.py 89.79% <ø> (-0.96%) ⬇️
wradlib/ipol.py 94.19% <100%> (+0.03%) ⬆️
wradlib/zonalstats.py 86.77% <100%> (+0.05%) ⬆️
wradlib/util.py 81.34% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e3571...20f7473. Read the comment docs.

@kmuehlbauer kmuehlbauer added this to the Release 0.10.0 milestone Mar 23, 2017
@kmuehlbauer
Copy link
Member Author

The py2.7 Travis build is "Killed", which means memory over consumption... Will try to investigate this. The py3.5 and py3.6 builds running fine.

@kmuehlbauer kmuehlbauer force-pushed the raster-handling branch 2 times, most recently from cfd35c0 to df97214 Compare March 29, 2017 07:03
@kmuehlbauer
Copy link
Member Author

The py2.7 Travis build is "Killed", which means memory over consumption... Will try to investigate this. The py3.5 and py3.6 builds running fine.

See #139, which resolved this issue.

@kmuehlbauer
Copy link
Member Author

@heistermann

This is ready to go! I tried to trace down all uses of the changed/deprecated functions and use the new implementation instead. Could you have a final review?

@kmuehlbauer kmuehlbauer mentioned this pull request Mar 31, 2017
3 tasks
@kmuehlbauer kmuehlbauer self-assigned this Mar 31, 2017
@kmuehlbauer kmuehlbauer requested a review from heistermann March 31, 2017 12:10
Copy link
Collaborator

@heistermann heistermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being so lazy and slow on this. This is really great - from tracking down the problem towards implementing a solution. Thanks, Kai! Any further issues can be follwoed up in master, if required.

@kmuehlbauer kmuehlbauer changed the title WIP: Raster handling ENH: Raster handling Mar 31, 2017
@kmuehlbauer kmuehlbauer merged commit f852563 into wradlib:master Mar 31, 2017
@kmuehlbauer kmuehlbauer deleted the raster-handling branch March 31, 2017 12:47
kmuehlbauer added a commit that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants