-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Raster handling #137
ENH: Raster handling #137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 82.6% 82.69% +0.08%
==========================================
Files 18 18
Lines 4341 4467 +126
==========================================
+ Hits 3586 3694 +108
- Misses 755 773 +18
Continue to review full report at Codecov.
|
…d `read_gdal_projection`
The py2.7 Travis build is "Killed", which means memory over consumption... Will try to investigate this. The py3.5 and py3.6 builds running fine. |
cfd35c0
to
df97214
Compare
df97214
to
72f6d01
Compare
See #139, which resolved this issue. |
719fea2
to
265ee2c
Compare
83d5572
to
9acecb3
Compare
This is ready to go! I tried to trace down all uses of the changed/deprecated functions and use the new implementation instead. Could you have a final review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being so lazy and slow on this. This is really great - from tracking down the problem towards implementing a solution. Thanks, Kai! Any further issues can be follwoed up in master, if required.
This PR handles the issues outline in #135
new functions
georef.create_raster_dataset
(data, coords, proj -> dataset)georef.extract_raster_dataset
(dataset -> data, coords, proj)georef.set_raster_origin
(flip data and coords, if necessary)georef.reproject_raster_dataset
(and resampling)io.write_raster_dataset
(write to disc)util.get_raster_origin
(returnsupper
orlower
)deprecated functions
io.to_AAIGrid
andto_GeoTIFF
io.read_raster_dataset
(the magic needed in this function isn't worth the work)georef.resample_raster_dataset
other fixes
zonalstats.DataSource.dump_raster
to use new functionalityio.read_safnwc
(proj4/wkt-handling)notebooks/fileio/wradlib_gis_export_example.ipynb
georef.read_gdal_values
to read multi band datautil.find_bbox_indices
to account forlower
orupper
origin data/coordsipol.cart2irregular_spline
to account for data/coords origin