Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Rework ZR #408

Merged
merged 3 commits into from Feb 20, 2020
Merged

ENH: Rework ZR #408

merged 3 commits into from Feb 20, 2020

Conversation

@kmuehlbauer
Copy link
Member

kmuehlbauer commented Feb 18, 2020

This makes zr.z_to_r_enhanced capable of handling mutlidimensional arrays. It also uses a convolution sum for creation of shower index (maximizing performance). All other implementations have bee removed.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #408 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   89.71%   89.46%   -0.25%     
==========================================
  Files          35       34       -1     
  Lines        6910     6828      -82     
==========================================
- Hits         6199     6109      -90     
- Misses        711      719       +8     
Flag Coverage Δ
#wradlibtests 89.46% <78.84%> (-0.24%) ⬇️
Impacted Files Coverage Δ
wradlib/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccd670...ec0ac08. Read the comment docs.

@kmuehlbauer kmuehlbauer merged commit cadb9b2 into wradlib:master Feb 20, 2020
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 78.84% of diff hit (target 89.71%)
Details
codecov/project 89.46% (+-0.25%) compared to cccd670
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wradlib.wradlib Build #20200219.2 succeeded
Details
@kmuehlbauer kmuehlbauer deleted the kmuehlbauer:rework-zr branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.