Implement Process.exePath
#47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimyr
force-pushed
the
process.exePath
branch
from
7aa8d1f
to
92b8805
Compare
joshgoebel
suggested changes
Apr 25, 2021
| { | ||
| wrenEnsureSlots(vm, 1); | ||
|
|
||
| char buffer[WREN_PATH_MAX * 2 + 1]; |
There was a problem hiding this comment.
We should really be using WREN_PATH_MAX everywhere... does it need to be increased or is there some reason we need much more storage here - in which case I'd suggest we may need another constant vs hard-coding this behavior in multiple places.
|
Hm, ok but we can only guess why? 😕 |
|
I believe this needs to be just @vladimyr Would you want to submit an updated PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement static getter
exePathfor theProcessclass.