Skip to content

Commit

Permalink
Disable 32 bit macOS Build
Browse files Browse the repository at this point in the history
With the latest XCode it looks like 32 bit builds are deprecated. This
causes build warnings which fail the libuv build. This commit remvoves
the 32 bit arch from the macOS libuv build, and stops building the 32
build on Travis.
  • Loading branch information
iwillspeak committed Feb 12, 2019
1 parent 52c16b4 commit ccb9ba3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Expand Up @@ -39,3 +39,6 @@ ipch/
*.user
*.userosscache
*.sln.docstates

# macOS XCode build cache
deps/libuv/build/XCBuildData/
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -6,7 +6,7 @@ compiler:
- gcc
- clang
env:
- WREN_OPTIONS="" CI_ARCHS="ci_32 ci_64"
- WREN_OPTIONS="" CI_ARCHS="ci_64"
- WREN_OPTIONS="-DWREN_NAN_TAGGING=0" CI_ARCHS="ci_64"

# Automatically build and deploy docs.
Expand Down
2 changes: 1 addition & 1 deletion util/build_libuv.py
Expand Up @@ -26,7 +26,7 @@ def build_libuv_mac():
run([
"xcodebuild",
# Build a 32-bit + 64-bit universal binary:
"ARCHS=i386 x86_64", "ONLY_ACTIVE_ARCH=NO",
"ARCHS=x86_64", "ONLY_ACTIVE_ARCH=NO",
"BUILD_DIR=out",
"-project", LIB_UV_DIR + "/uv.xcodeproj",
"-configuration", "Release",
Expand Down

0 comments on commit ccb9ba3

Please sign in to comment.