New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(docs) Fiber.abort can be passed an object #1015
base: main
Are you sure you want to change the base?
Conversation
There are some redundant whitespace changes in this PR. |
We need an Other projects I work on assume auto-removal of trailing spaces, and I think that's a good default usually. |
doc/site/modules/core/fiber.markdown
Outdated
@@ -8,12 +8,16 @@ A lightweight coroutine. [Here][fibers] is a gentle introduction. | |||
|
|||
### Fiber.**abort**(message) | |||
|
|||
Raises a runtime error with the provided message: | |||
Raises a runtime error with the provided message. `message` may also be an object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message
, in fact, can be any Wren value, as far as I know. See src/vm/wren_value.h, struct ObjFiber
--- it has a Value error
. Would you be willing to update the suggested language to note that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can click the +/- and propose specific changes... I'm fine with whatever here as long as it adds clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you, please? My Wren time is currently taken up by the switch-statement PR. I appreciate it!
I took another pass at this. |
Better now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Rob Loach <robloach@gmail.com>
No description provided.