Updated hardcoded est-end to 2012-06-25 #207

Merged
merged 2 commits into from Aug 30, 2012

Conversation

Projects
None yet
3 participants
Contributor

robinkraft commented Aug 23, 2012

Best to update this default for good measure.

Contributor

sritchie commented Aug 23, 2012

Actually, I'd rather get this hardcoded value out and into a config parameter. Let's fix this issue now while it's open in a pull req.

Contributor

danhammer commented Aug 23, 2012

We've got a deadline approaching. @sritchie, if you want to take this on, then we'll keep it open. Otherwise, #shipit.

Contributor

sritchie commented Aug 23, 2012

I'll do it, it'll take 5 minutes, but you guys would have to supply the end date as part of the command line call. Sound good?

Contributor

robinkraft commented Aug 23, 2012

Yup!

On Aug 23, 2012, at 10:41 AM, Sam Ritchie notifications@github.com wrote:

I'll do it, it'll take 5 minutes, but you guys would have to supply the end date as part of the command line call. Sound good?


Reply to this email directly or view it on GitHub.

@sritchie sritchie commented on the diff Aug 23, 2012

src/clj/forma/hadoop/jobs/scatter.clj
@@ -280,7 +281,7 @@
est-map
(hfs-seqfile cleanup-path)
(hfs-seqfile adjusted-fire-path))))
-
@sritchie

sritchie Aug 23, 2012

Contributor

This was all whitespace...

Contributor

robinkraft commented Aug 23, 2012

Thanks @sritchie, lgtm!

Contributor

sritchie commented Aug 23, 2012

Do you need to change any docs about the scripts you run? You're seeing the extra command line param?

robinkraft merged commit d6f80cf into develop Aug 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment