New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #1

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link
Contributor

SamWhited commented Dec 18, 2018

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go (although the import path doesn't change with this library, so it doesn't matter much here).

Because this library has no external dependencies and is still below version 2, the go.mod file is fairly simple. The only other thing that would need to be done is to create a semver compatible tag after this patch is merged (eg. v1.0.1) to allow other things to pin to that version without having to use the special commit-based version string.

Also: I notice that the various write.as packages are a bit inconsistent in how and where they live. Eg. go-writeas uses a self-hosted gopkg.in and has an import path at code.write.as, this package has a GitHub import, and still others use a code.as import. Is there something you plan to standardize on? Modules make the gopkg.in style imports unnecessary (it might even be broken, I'm not sure), but otherwise it's probably best to decide what the final import path will be before setting it in a module (EDIT: if you prefer to have things on a domain that you control and is distinct from the source repo's domain, there's also the option of using a meta tag which go get understands to redirect from whatever domain you choose).

Thank you for your consideration.

@SamWhited SamWhited referenced this pull request Dec 18, 2018

Merged

Support Go Modules #10

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Dec 22, 2018

Thanks, I need to familiarize myself with Go modules first, but I'd be happy to support that in this library.

As for the organization, the go-writeas versioning was used only so I could make some breaking changes and include them in the CLI. And I didn't want to set up a repo with the naming that gopkg.in required, so I created a self-hosted version and used that, instead. I'll most likely keep these libraries on github as the canonical location.

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Dec 22, 2018

Sure thing; let me know if there's any way I can help or anything I can clarify WRT modules.

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Jan 4, 2019

Okay, I think I got the basics of modules now. Merging now, and then I'll make a v1.0.1 tag. Thanks again @SamWhited!

@thebaer thebaer merged commit 677d52f into writeas:master Jan 4, 2019

@SamWhited SamWhited deleted the SamWhited:support_modules branch Jan 4, 2019

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Jan 4, 2019

Actually, went with v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment