Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collection listing #31

Merged
merged 4 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@robjloranger
Copy link
Member

commented Jun 7, 2019

adds subcommand colls
lists collections for authenticated user
supports -url flag for listing collection URLs

add collection listing
adds subcommand colls
lists collections for authenticated user
supports -url flag for listing collection URLs
@thebaer

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Have only read the code, but it's looking good so far. Only feedback is I'd say we make the subcommand "blogs" instead of "colls", since "collections" is only used internally.

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

updated @thebaer

@thebaer
Copy link
Member

left a comment

Looks and works great overall. But besides returning errs in DoFetchCollections, I noticed some spacing issues with my blogs:

Alias        Title        
matt         matt         
aa-blog-placeaa blog place
blog         write.as

There's no space after aa-blog-place. Could we tweak the TabWriter to make sure we always have at least one space after the first column?

Show resolved Hide resolved api/api.go Outdated
Show resolved Hide resolved api/api.go Outdated

@thebaer thebaer added this to the 2.0 milestone Jun 10, 2019

return proper errors in CmdCollections
fix tabwriter padding
@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

all set here @thebaer

@thebaer

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Looks great. Thanks!

@thebaer thebaer merged commit 0a9f92a into version-two Jun 10, 2019

@robjloranger robjloranger deleted the T602-list-colls branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.