Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claim posts #34

Merged
merged 4 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@robjloranger
Copy link
Member

commented Jun 10, 2019

No description provided.

robjloranger and others added some commits Jun 10, 2019

add claim posts to writeas CLI
this adds the ability to claim local posts under an authenticated
account.

removePost is now exported for use the claim command
move to version two of go-writeas
this changes imports to use the github import path
github.com/writeas/go-writeas/v2
Tweak post claim logging
- Presents a summary before making the request when verbose (-v) enabled
- Successful claims only shown with verbose (-v) enabled
- Failed claims now always mention cause of failure
- A summary of successes / failures shows after logging any failures,
  when verbose (-v) enabled

Ref T194

@thebaer thebaer added this to the 2.0 milestone Jun 11, 2019

@thebaer

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thanks @robjloranger, this is great.

I found a nil pointer panic when a post failed to be claimed. Since it's sorta difficult to make these errors happen, I just went ahead and fixed it.

I like that you included logs with the status of each post. I just tweaked it so successes only show up when running with the -v (verbose) flag. Errors will still always show up on os.Stderr. But if all goes well when someone runs writeas claim, there will be no output -- which is the same as writeas delete and other subcommands.

@robjloranger
Copy link
Member Author

left a comment

Nice, thanks matt

@thebaer

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

No problem 👍 merging now.

@thebaer thebaer merged commit 13bf829 into version-two Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.