Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tar is bombing the cwd with files #160

Closed
qwazix opened this issue Aug 8, 2019 · 3 comments · Fixed by #164
Closed

Tar is bombing the cwd with files #160

qwazix opened this issue Aug 8, 2019 · 3 comments · Fixed by #164
Assignees
Labels

Comments

@qwazix
Copy link
Collaborator

@qwazix qwazix commented Aug 8, 2019

Describe the bug

Untarring the writefreely release with the customary tar xzvf writefreely_x.x.x_os_arch.tar.gz explodes littering the current directory with files. The tar should have a root directory so that untarring creates only one directory in the cwd.

Steps to reproduce (if necessary)

Steps to reproduce the behavior:

  1. Download writefreely
  2. tar xzvf writefreely_x.x.x_os_arch.tar.gz
  3. The contents litter the current directory

Expected behavior

A single directory named writefreely should be extracted with the rest of the files placed inside it

Version or last commit: 0.10.0

@thebaer thebaer added the build label Aug 8, 2019
@thebaer

This comment has been minimized.

Copy link
Member

@thebaer thebaer commented Aug 8, 2019

Thanks, this should be a quick fix. Just need to add the dir in make release.

@robjloranger

This comment has been minimized.

Copy link
Member

@robjloranger robjloranger commented Aug 8, 2019

We need to update the update script afterward. Then I will update the one click image script.

@thebaer

This comment has been minimized.

Copy link
Member

@thebaer thebaer commented Aug 8, 2019

Yep, though this fix will go out with v0.11 -- so we should be sure not to include the change in the v0.10 image we're going to release.

If either of you want to tackle this fix, feel free to assign yourself the issue here and open a PR.

@robjloranger robjloranger self-assigned this Aug 8, 2019
@robjloranger robjloranger mentioned this issue Aug 9, 2019
1 of 1 task complete
@thebaer thebaer closed this in #164 Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.