Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including image descriptions on page description makes the description meta less readable #306

Open
ricardojmendez opened this issue Apr 28, 2020 · 1 comment

Comments

@ricardojmendez
Copy link

@ricardojmendez ricardojmendez commented Apr 28, 2020

Describe the bug

If there is an image at the start of the article, and this image includes a description, the meta for the article will include it, followed by the first paragraph.

This causes article previews to end up being less readable.

I'd have expected the description meta to start with the first paragraph.

Steps to reproduce (if necessary)

  • Create a new article
  • Add an title, then before the first paragraph, include an image with a description
  • The page's meta description will include the image description

Expected behavior

The page's description should not include anything about the image and start at the first paragraph

@thebaer
Copy link
Member

@thebaer thebaer commented May 15, 2020

Thanks for catching this, @ricardojmendez! Definitely want to improve this.

I've opened an issue for this in the library that processes text for the page descriptions: writeas/go-strip-markdown#2. After fixing this there, we'll get it into WF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.