Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links have rel="nofollow" #314

Open
Crocmagnon opened this issue May 16, 2020 · 1 comment
Open

Links have rel="nofollow" #314

Crocmagnon opened this issue May 16, 2020 · 1 comment

Comments

@Crocmagnon
Copy link

@Crocmagnon Crocmagnon commented May 16, 2020

Describe the bug

Links added by the user on an article or a pinned page have a rel="nofollow" attribute.

Steps to reproduce (if necessary)

Add a link in an article, either with markdown or HTML.
If the link is HTML and the user explicitly specifies another value for the rel attribute, this value is overridden when rendering the page.

Expected behavior

I see two issues with this:

  • This prevents Mastodon profile validation (which requires a rel="me")
  • This may reduce the visibility of the blogs since SE apparently respect this directive

From the MDN:

Indicates that the linked document is not endorsed by the author of this one, for example if it has no control over it, if it is a bad example or if there is commercial relationship between the two (sold link).

IMHO this:

  • shouldn't be applied at all on internal links (links to href="#something" or to other pages of the blog)
  • should be applied by default on external links if the user doesn't specify anything else via a custom HTML anchor.

Application configuration

  • Single mode or Multi-user mode? single
  • Database? sqlite
  • Open registration? no
  • Federation enabled? yes

Version or last commit: 037fc40

@dimobelov
Copy link

@dimobelov dimobelov commented May 31, 2020

Yes, just add Config option follow/nofollow and use it here

return applyMarkdownSpecial(data, false, baseURL, cfg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.