Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #103: cannot change RTL post direction back to LTR #104

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@cenrak
Copy link

commented May 13, 2019

[Describe the pull request here...]
Provides a template-based solution to overcome not sending RTL's unchecked box value to the web application.

  • I have signed the CLA
@thebaer

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Thanks for taking a look at this! However, I think we should go with the API-based solution you mentioned in #103. Ideally, we'd recognize that we're updating post metadata from the web application (instead of the pure API) and set it to false if there is no checkbox value.

@thebaer thebaer referenced this pull request May 18, 2019

Closed

Add value attribute to RTL checkbox #106

1 of 1 task complete
@thebaer

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@cenrak I went with the API-side solution in #110 -- could you check that out and let me know if that works for you?

@thebaer thebaer closed this May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.