Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-bindata as a module dependency #107

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
2 participants
@robjloranger
Copy link
Member

commented May 18, 2019

This adds https://github.com/jteeuwen/go-bindata as a module dependency
as the make target 'build' will result in it's addition.

We could leave it out but user's running make build will get unstaged changes as a result. This would only affect those developing writefreely, not so much for end users just building from source.


  • I have signed the CLA
Add go-bindata as a module dependency
This adds https://github.com/jteeuwen/go-bindata as a module dependency
as the make target 'build' will result in it's addition.
@thebaer

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Thanks! Could you explain what you mean by "users running make build will get unstaged changes as a result"?

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

Oh sure, on running that myself from the current develop branch. I then have modifications to the mentioned files as building pulls this in as a dependency. So I see changes in the repo to be staged for a commit.

@thebaer thebaer force-pushed the develop branch from bcd07d8 to 2fdd583 May 18, 2019

@thebaer

This comment has been minimized.

Copy link
Member

commented May 19, 2019

Ah, got it. So before this PR, running make build modifies the go.mod and go.sum files?

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

Ya exactly, without already having it installed in your go path. I haven't tested but I assume based on the make file, if you had it installed previously it would not call go get.

@thebaer thebaer added this to the 0.10 milestone May 20, 2019

@thebaer

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Got it, makes sense. Thanks! Merging now.

@thebaer thebaer merged commit b6da5d9 into develop May 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@robjloranger robjloranger deleted the go-bindata-as-dep branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.