Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Merge dev branch into master #108
Changes RTL on the server side to use integers instead of boolean values. This has the advantage of supporting the
That third change requires substantial review. Please don't merge this PR without making sure they do what we want them to.
The initial condition that prompted my change was that the database was storing the value as
However, it occurs to me that moving from true/false/NULL to an integer-based system allows for certain additional features; for example, we might expand to
I also confess that I have a distaste for NULL being used as a meaningful state, but that's just me.
Right, that's how the Go database drivers store booleans, since MySQL and SQLite don't have a native boolean type (in MySQL it's stored as a
In the case of this field, it exists for a very specific purpose: to indicate whether a post should display left-to-right (for languages like English) or right-to-left (for languages like Arabic). The optional
As for other text directions, I'd say that'd make most sense as an additional column in the
Lastly, we need to be careful with type changes that involve the database. With this change, any time you