Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting changes from previous commits #109

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
2 participants
@joyeusenoelle
Copy link
Collaborator

commented May 18, 2019

This reverts changes to RTL processing from the develop branch.


  • I have signed the CLA

joyeusenoelle added some commits May 17, 2019

Comment out unused i18n package
I suspect this will be used in the future so I'm not removing it entirely.

@joyeusenoelle joyeusenoelle requested a review from thebaer May 18, 2019

@thebaer thebaer force-pushed the develop branch from bcd07d8 to 2fdd583 May 18, 2019

@thebaer

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Thanks, I went ahead and just reverted develop back to where it was before, moving those previous commits to the rtl-changes branch.

Going forward, let's follow this flow of creating a new feature branch for each new feature / pull request.

@thebaer thebaer closed this May 18, 2019

@joyeusenoelle joyeusenoelle deleted the rtl-correct branch May 18, 2019

@joyeusenoelle

This comment has been minimized.

Copy link
Collaborator Author

commented May 18, 2019

I actually thought I had, but it turned out the branch I'd created was only attached to the local version of the develop branch, and when I tried to get it to push to the remote it pushed straight to origin/develop. I ended up having to re-clone the repo to get git to start behaving properly again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.