Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change delete post authentication logic #117

Merged
merged 1 commit into from Jun 5, 2019
Merged

change delete post authentication logic #117

merged 1 commit into from Jun 5, 2019

Conversation

@robjloranger
Copy link
Member

robjloranger commented Jun 5, 2019

this reorders the logic for checking authentication on post deletes to
first check for a provided edit token and after check for an access
token or auth'd user.


  • I have signed the CLA
this reorders the logic for checking authentication on post deletes to
first check for a provided edit token and after check for an access
token or auth'd user.
@robjloranger robjloranger requested a review from thebaer Jun 5, 2019
@robjloranger
Copy link
Member Author

robjloranger commented Jun 5, 2019

after writeas/go-writeas#17 I can test this on my dev instance

this will need to be tested on development.write.as

Copy link
Member

thebaer left a comment

As mentioned in T612, if this works as expected when you test, I think this is a good solution 👍

@thebaer thebaer marked this pull request as ready for review Jun 5, 2019
@thebaer thebaer added this to the 0.10 milestone Jun 5, 2019
@thebaer
Copy link
Member

thebaer commented Jun 5, 2019

Since testing went well, this is good to go! Thanks @robjloranger!

@thebaer thebaer merged commit b2a9429 into develop Jun 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the T612 branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.