Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single-user instance issues #145

Merged
merged 4 commits into from Aug 7, 2019
Merged

Fix single-user instance issues #145

merged 4 commits into from Aug 7, 2019

Conversation

@thebaer
Copy link
Member

thebaer commented Jul 22, 2019

While running a single-user instance on https://matt.writefreely.dev I've noticed some (mostly superficial) issues, and documented them here:

  • “Public” option shows on blog Customize page (should never be there in this mode)
  • Pinning a post links to /matt/about instead of /about
  • Instance-level About page shows at the bottom of user pages (should never show in this mode)
  • Drafts page shows “Find your blog posts from the Blogs page.” (should never show in this mode)

This PR aims to fix those issues.

thebaer added 2 commits Jul 22, 2019
Previously, these links showed up on user backend pages on a single-user
instance, despite them not working / only being applicable on multi-user
instances.
@thebaer thebaer added this to the 0.11 milestone Jul 22, 2019
- This removes copy mentioning the Blogs page, which isn't used on
  single-user instances
- This fixes the "Start writing" link, which on a single-user instance
  would've gone to the blog index, rather than the editor
@thebaer thebaer changed the title Fix single user issues Fix single-user instance issues Jul 22, 2019
Previously, the URL of the dynamically-added pinned post on a
single-user instance would include the username, causing the link to go
to a non-existent page. This fixes that.
@thebaer
Copy link
Member Author

thebaer commented Aug 7, 2019

Fixed pinned posts and haven't heard about any other single-user issues, so merging now.

@thebaer thebaer merged commit de1a51d into develop Aug 7, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thebaer thebaer deleted the fix-single-user branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.