Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting default blog visibility on instance #148

Merged
merged 5 commits into from Aug 7, 2019

Conversation

@thebaer
Copy link
Member

commented Aug 1, 2019

This adds a new default_visibility config value that lets an instance admin set the visibility of newly created collections: Unlisted (current default), Public, or Private.

This can also be set via the Admin UI.

Resolves T675.

thebaer added some commits Aug 1, 2019

Support configuring default collection visibility
This adds a new `default_visibility` config value that lets an instance
admin set the visibility of newly created collections.

Ref T675

@thebaer thebaer added this to the 0.11 milestone Aug 1, 2019

@thebaer thebaer changed the title Default visibility Support setting default blog visibility on instance Aug 1, 2019

@thebaer

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Need to verify that creating a collection via API still works, then we can merge.

thebaer added some commits Aug 7, 2019

Set default visibility in datastore.CreateCollection
instead of updating it later. This is more correct behavior, prevents an
additional query, and ensures that potential collection-creation when
claiming posts also respects the default (which it didn't before).

Ref T675
Return correct `public` state on collection creation
(in returned JSON data)

Ref T675
@thebaer

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Verified collection creation via API works, refactored some things, and added documentation. Merging now.

@thebaer thebaer merged commit adfcc82 into develop Aug 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.