Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tar bombs #164

Open
wants to merge 2 commits into
base: develop
from

Conversation

@robjloranger
Copy link
Member

commented Aug 9, 2019

this changes the release targets in the Makefile to use a subdirectory
of the format BINARYNAME_GITREV so extracting the archive results in a
single directory.


  • I have signed the CLA

closes #160

fix tar bombs
this changes the release targets in the Makefile to use a subdirectory
of the format BINARYNAME_GITREV so extracting the archive results in a
single directory.
@thebaer

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

What do you think if we name the directory writefreely instead of including the version info? That should make installation / upgrading easier by maintaining existing paths, e.g.:

tar -C /var/www -xzf writefreely_0.10.0_linux_amd64.tar.gz

would always produce /var/www/writefreely.

@joyeusenoelle

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

The only problem I can think of is a rare edge case where someone wants multiple versions installed, but they can do that manually so I'm not sure we need to care about it.

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

sure, sounds good to me

change subdirectory to writefreely
instead of writefreely_versionstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.