Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for lessc executable in any location #165

Merged
merged 7 commits into from Sep 20, 2019
Merged

check for lessc executable in any location #165

merged 7 commits into from Sep 20, 2019

Conversation

@robjloranger
Copy link
Member

robjloranger commented Aug 9, 2019

previously the checks were explicit locations which does not work when
using something like nvm to manage node packages and versions.

this checks for the executable and sets the script variable LESSC to the
full path of the one found.
if none was found the make command will error.


  • I have signed the CLA
previously the checks were explicit locations which does not work when
using something like nvm to manage node packages and versions.

this checks for the executable and sets the script variable LESSC to the
full path of the one found.
if none was found the make command will error.
@robjloranger robjloranger marked this pull request as ready for review Aug 28, 2019
@thebaer thebaer added this to the 0.11 milestone Sep 4, 2019
@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Sep 18, 2019

When running make install from the less dir I got:

Makefile:4: *** recipe commences before first target.  Stop.

So I changed the file a bit, and that seemed to fix it. Let me know if it messes anything up when you try it.

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 18, 2019

works for me still as well 👍

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Sep 18, 2019

Great, and just to confirm, it works when lessc isn't previously installed?

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 18, 2019

hmm, no it doesn't seem to detect the binary is missing.

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 18, 2019

this one is weird, I guess the variable is never undefined but not always what we want?

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Sep 18, 2019

Hmm, yeah... Maybe an empty check instead would do it?

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 18, 2019

white space was throwing me around, double check this one for me

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Sep 20, 2019

It seems to be catching it, but now make install doesn't work..

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 20, 2019

weird, what is the error? it works .. on my machine 🤣

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Sep 20, 2019

Heh 😄 Error is:

Makefile:2: *** "less is not installed, please run install-less.sh".  Stop.

Instead, make install should run install-less.sh, etc.:

install :
./install-less.sh
$(MAKE) all

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 20, 2019

oooh, make install in less I get it. fixed? now 😁

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Sep 20, 2019

Great, now let's just make sure all the stylesheets are still generated :)

accidentally removed two lines from make all

fix check when trying to install lessc
@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 20, 2019

this is a mess, I fix one issue and the other reappears. Maybe we need to use some bash instead.

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 20, 2019

ok, ready for another test @thebaer

Copy link
Member

thebaer left a comment

Perfect 👍 Just tweaked the error message a bit. Good to go!

@thebaer thebaer merged commit afa3792 into develop Sep 20, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@thebaer thebaer deleted the lessc-check branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.