Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing collection hostname #171

Open
wants to merge 1 commit into
base: develop
from

Conversation

@robjloranger
Copy link
Member

commented Aug 12, 2019

GetCollections and GetPublishableCollections now take a hostname
parameter to allow setting the collecion hostname.

All collections used in memory now have their hostname set.


  • I have signed the CLA
    closes #161
fix missing collection hostname
GetCollections and GetPublishableCollections now take a hostname
parameter to allow setting the collecion hostname.

All collections used in memory now have their hostname set.
@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

This does seem like a lot of extra work compared to storing the hostname in the collection. The post could then get it's hostname from it's associated collection and we wouldn't be passing it around.

Then for things like export, we could omit the hostname value to avoid issues moving blogs across deployments.

But that is for another day, this fixes the mentioned issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.