Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add update checks #175

Merged
merged 5 commits into from Feb 14, 2020
Merged

add update checks #175

merged 5 commits into from Feb 14, 2020

Conversation

@robjloranger
Copy link
Member

robjloranger commented Aug 29, 2019

includes cache of latest version and page to view if updates are
available with a link to the latest update's release notes and a link to
check for the latest update now, refreshing the cache manually.


  • I have signed the CLA
includes cache of latest version and page to view if updates are
available with a link to the latest update's release notes and a link to
check for the latest update now, refreshing the cache manually.
@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Aug 29, 2019

hah, I'm using go 1.12 and didn't realize strings.ReplaceAll was new

@robjloranger

This comment has been minimized.

Copy link
Member Author

robjloranger commented Sep 6, 2019

I might just add some basic tests before we get this in.

robjloranger and others added 2 commits Sep 9, 2019
- removes the parameter for newVersionCheck as was not being used
- changes newUpdatesCache to take expiry parameter for possible future
configuration option
- adds basic test quite to verify all cache fucntions work as expected
@thebaer thebaer added this to the 0.12 milestone Nov 11, 2019
@thebaer thebaer removed this from the 0.12 milestone Feb 10, 2020
@thebaer thebaer added this to the 0.12 milestone Feb 14, 2020
Copy link
Member

thebaer left a comment

Thanks @robjloranger -- this looks good! Worked well on some preliminary tests. Might tweak the design a bit as part of #264, but this is good to merge now!

@thebaer thebaer merged commit f799260 into develop Feb 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.