Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mathjax in binaries #181

Open
wants to merge 5 commits into
base: develop
from

Conversation

@robjloranger
Copy link
Member

commented Sep 11, 2019

removes the submodule for mathjax and instead includes a copy of the script

ref #176, will need a tag and new release to close


  • I have signed the CLA
include mathjax script
this includes a copy of mathjax@3.0.0/es5/tex-mml-chtml.js

@robjloranger robjloranger requested a review from thebaer Sep 11, 2019

@thebaer

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

I think we also need the fonts and images from the library, right?

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

I'm not certain, the docs just say to link the one script.

I did notice that the body is not being parsed properly though so I will need to see what's going on here.

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

this uses the svg version which does not require any external fonts
Screenshot from 2019-09-11 14-17-28

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

something is weird again, this was working when I took that shot but now it's not 🤔

add all mathjax components
with only the single script, there were still many requests to a CDN.
this fixes that and speed up the page load a bit as well.
Revert "add all mathjax components"
This reverts commit 2514529.
@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

I didn't want to but it seems the best solution. I added the full build of mathjax components and assets to avoid unwanted requests to CDNs.

Firefox was/is just being weird and caching things, even with cache disabled.. other browsers are working as expected only using local files. tested with [chrome, chromium, opera, brave, midori]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.