Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gogs/gogs/pkg/tool dependency #182

Merged
merged 3 commits into from Sep 13, 2019

Conversation

@robjloranger
Copy link
Member

commented Sep 11, 2019

this borrows some code from github.com/gogs/gogs/pkg/tool to avoid
pulling it in as a dependency, along with many other indirect deps.

closes #156


  • I have signed the CLA
remove gogs/gogs/pkg/tool dependency
this borrows some code from github.com/gogs/gogs/pkg/tool to avoid
pulling it in as a dependency, along with many other indirect deps.

@robjloranger robjloranger requested a review from thebaer Sep 11, 2019

@thebaer thebaer force-pushed the rm-gogs-pkg-tool branch from d13e321 to 66b0945 Sep 13, 2019

@thebaer

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

I updated the file to include their copyright information. Otherwise I'd say that we should put this in its own package (maybe appstats?), to keep the writefreely pkg clean and make it reusable.

@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

I'll make that change shortly

@thebaer
Copy link
Member

left a comment

Perfect, looks good! Thanks.

@thebaer thebaer merged commit 5310e6d into develop Sep 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thebaer thebaer deleted the rm-gogs-pkg-tool branch Sep 13, 2019

@thebaer thebaer added this to the 0.11 milestone Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.