Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dates to posts on collections w/ blog format #190

Open
wants to merge 3 commits into
base: develop
from

Conversation

@robjloranger
Copy link
Member

commented Oct 2, 2019

This adds conditional date placement on collection posts using the 'blog' format.

When dates are shown without a post title, the date is formatted as the body text with top placement.


ref T669

  • I have signed the CLA
robjloranger added 2 commits Oct 2, 2019
the old class was dt-published, at first it was split to keep the
display: block without the rest. this changes the published class to
subtle to be more logical
@robjloranger

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

I changed the chorus template as well, quick to revert if you prefer. I thought it would be good to be consistent

Copy link
Member

left a comment

Still need to review more, but just a few quick notes after skimming the code:

  • we should switch back to dt-published as the class name, as it's a microformats property
  • let's extract the shared CSS between templates into less/core.less
also changes less function article-title to have a bottom margin of
0.5em as it was being reset on both post views. this also brings
anonymous posts into a consistent style with the rest.
@robjloranger robjloranger referenced this pull request Oct 3, 2019
1 of 1 task complete
@thebaer thebaer added this to the 0.11 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.