Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dates to posts on collections w/ blog format #190

Closed
wants to merge 3 commits into from

Conversation

@robjloranger
Copy link
Member

robjloranger commented Oct 2, 2019

This adds conditional date placement on collection posts using the 'blog' format.

When dates are shown without a post title, the date is formatted as the body text with top placement.


ref T669

  • I have signed the CLA
robjloranger added 2 commits Oct 2, 2019
the old class was dt-published, at first it was split to keep the
display: block without the rest. this changes the published class to
subtle to be more logical
@robjloranger
Copy link
Member Author

robjloranger commented Oct 2, 2019

I changed the chorus template as well, quick to revert if you prefer. I thought it would be good to be consistent

Copy link
Member

thebaer left a comment

Still need to review more, but just a few quick notes after skimming the code:

  • we should switch back to dt-published as the class name, as it's a microformats property
  • let's extract the shared CSS between templates into less/core.less
also changes less function article-title to have a bottom margin of
0.5em as it was being reset on both post views. this also brings
anonymous posts into a consistent style with the rest.
@robjloranger robjloranger mentioned this pull request Oct 3, 2019
1 of 1 task complete
@thebaer thebaer added this to the 0.11 milestone Oct 10, 2019
@thebaer thebaer modified the milestones: 0.11, 0.12 Nov 8, 2019
@thebaer
Copy link
Member

thebaer commented Jan 9, 2020

Thanks for giving this a shot, but a lot of the layout got messed up here, and it looks like it changes the previous header spacing we had (which ideally we'd avoid). So I took another stab at this in #235. If that works, we'll merge that instead.

@thebaer thebaer closed this Jan 9, 2020
@thebaer thebaer removed this from the 0.12 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.