Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add silenced warning on invites page #208

Merged
merged 3 commits into from Feb 9, 2020
Merged

add silenced warning on invites page #208

merged 3 commits into from Feb 9, 2020

Conversation

@robjloranger
Copy link
Member

robjloranger commented Nov 11, 2019

This adds the same warnng about a user account being silence on the view invites page as a silenced use can no longer create invites.


  • I have signed the CLA
@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Feb 9, 2020

Part of T661.

Ref T661
@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Feb 9, 2020

Since the user can't create invites, I updated the form to also reflect this fact. Now elements are disabled and the submit button includes an explanation tooltip.

Thanks for this! Merging now.

@thebaer
thebaer approved these changes Feb 9, 2020
@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Feb 9, 2020

Ah, also page rendering shouldn't catastrophically fail when the IsUserSuspended check fails. The 500 will confuse people and the error isn't that critical. Fixed that, merging now.

@thebaer thebaer merged commit 252d59d into develop Feb 9, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the silence-invites branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.