Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fediverse post IDs #214

Merged
merged 2 commits into from Nov 27, 2019
Merged

Fix fediverse post IDs #214

merged 2 commits into from Nov 27, 2019

Conversation

@thebaer
Copy link
Member

thebaer commented Nov 26, 2019

Previously, fetching ActivityStreams data about a post via /api/posts/ID, instead of /api/collections/ALIAS/posts/SLUG wouldn't include the instance's base URL in the post's id, causing federation issues. This fixes that.

It also includes the related fix in #212.

thebaer added 2 commits Nov 19, 2019
Previously, this check would return a "user not found" error when
retrieving a collection post by its post ID, e.g. /api/posts/abc123
instead of /api/collections/demo/posts/my-slug -- this happens
particularly when `Announce`ing a post in the fediverse. This change
fixes that.
Previously, fetching ActivityStreams data about a post via
/api/posts/ID, instead of /api/collections/ALIAS/posts/SLUG wouldn't
include the instance's base URL. This fixes that.
@thebaer thebaer added this to the 0.11.2 milestone Nov 26, 2019
@thebaer thebaer requested a review from robjloranger Nov 26, 2019
@thebaer thebaer changed the title Fix hostname fediverse Fix fediverse post IDs Nov 26, 2019
Copy link
Member

robjloranger left a comment

looks good as well, tested both endpoints locally

@thebaer

This comment has been minimized.

Copy link
Member Author

thebaer commented Nov 27, 2019

Thanks! Merging now.

@thebaer thebaer merged commit 88a3ed7 into hotfix-0.11.2 Nov 27, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the fix-hostname-fediverse branch Nov 27, 2019
@thebaer thebaer mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.