Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Provider: Slack #230

Merged
merged 15 commits into from Jan 3, 2020
Merged

OAuth Provider: Slack #230

merged 15 commits into from Jan 3, 2020

Conversation

@ngerakines
Copy link
Collaborator

ngerakines commented Dec 30, 2019

This PR introduces Slack specific functionality as part of the larger OAuth feature set.

This PR builds off of the functionality in #225.

Testing

  1. Create a Slack application

  2. Set the following configuration

    [oauth.slack]
    client_id = "<slack application client id>"
    client_secret = "<slack application client secret>"
    
  3. Browse to https://[local instance]/oauth/slack

  4. Continue authentication flow with Slack

  5. Arrive at the logged in user landing page with your newly created account.

Important: Be sure to set your instance to allow multiple users in configuration.


  • I have signed the CLA
ngerakines and others added 6 commits Dec 27, 2019
This gives us our standard logging and passes around errors with
impart.HTTPError.

Ref T705
@ngerakines ngerakines marked this pull request as ready for review Dec 31, 2019
@ngerakines ngerakines requested a review from thebaer Dec 31, 2019
@ngerakines ngerakines self-assigned this Dec 31, 2019
Copy link
Member

thebaer left a comment

Works great! Just a few pieces of feedback on error handling and cleanup. Otherwise, before merging this PR, I'd say we should get #231 merged and update this accordingly.

Lastly, is there any way to skip Slack's "Allow app" flow once a user has already authenticated?

parse/posts_test.go Outdated Show resolved Hide resolved
migrations/v1.go Outdated Show resolved Hide resolved
oauth_writeas.go Show resolved Hide resolved
oauth_writeas.go Show resolved Hide resolved
oauth_slack.go Show resolved Hide resolved
oauth_slack.go Show resolved Hide resolved
oauth.go Outdated Show resolved Hide resolved
oauth_slack.go Outdated Show resolved Hide resolved
@thebaer
thebaer approved these changes Jan 2, 2020
Copy link
Member

thebaer left a comment

Perfect! Looks and works great. Merging #231 then this.

Pass OAuth requests through OAuth handler
Copy link
Member

thebaer left a comment

Noticed a few last issues around authentication and user creation. With those fixed, this'll be good to go.

oauth.go Show resolved Hide resolved
oauth.go Outdated Show resolved Hide resolved
@thebaer
thebaer approved these changes Jan 3, 2020
Copy link
Member

thebaer left a comment

Excellent -- works great! Merging now.

@thebaer thebaer merged commit 97b2562 into develop Jan 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the T710-oauth-slack branch Jan 3, 2020
@thebaer thebaer added this to the 0.12 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.