Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass OAuth requests through OAuth handler #231

Merged
merged 4 commits into from Jan 2, 2020
Merged

Conversation

@thebaer
Copy link
Member

thebaer commented Dec 30, 2019

This gives us consistent logging on OAuth endpoints and passes around errors with impart.HTTPError, as we do elsewhere -- while keeping the current JSON schema for OAuth requests ({"error": "..."}).

@ngerakines curious about your thoughts on this -- whether it works or if it might cause issues down the road, e.g. with error handling for various request types.

Part of T705.

This gives us our standard logging and passes around errors with
impart.HTTPError.

Ref T705
@thebaer thebaer requested a review from ngerakines Dec 30, 2019
@thebaer thebaer changed the base branch from T705-oauth to develop Dec 31, 2019
@ngerakines ngerakines changed the base branch from develop to T710-oauth-slack Jan 2, 2020
@thebaer

This comment has been minimized.

Copy link
Member Author

thebaer commented Jan 2, 2020

Looks great! Merging now.

@thebaer thebaer merged commit 2486b3c into T710-oauth-slack Jan 2, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the oauth-wrapper branch Jan 2, 2020
@thebaer thebaer added this to the 0.12 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.