Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth registration improvements #232

Merged
merged 10 commits into from Jan 8, 2020
Merged

Conversation

@ngerakines
Copy link
Collaborator

ngerakines commented Jan 3, 2020

This PR improves the account creation flow through OAuth providers. Instead of immediately creating a user, a populated form is presented with suggested values. Some basic error handling is implemented.

Added

  • The /oauth/signup handler, template, and route.
  • The server.hash_seed configuration variable used to verify the integrity of oauth variables used in account creation.

Changed

  • The account creation behavior used when a user account should be created as a result of the oauth flow.

  • I have signed the CLA
@ngerakines ngerakines requested a review from thebaer Jan 3, 2020
@ngerakines ngerakines self-assigned this Jan 3, 2020
@ngerakines ngerakines marked this pull request as ready for review Jan 3, 2020
@ngerakines ngerakines changed the title T712 oauth registration improvements OAuth registration improvements Jan 3, 2020
Copy link
Member

thebaer left a comment

Looking really good! Just have some feedback on validation and the signup form.

I'm going to play around with the design of the login page, making the buttons graphical and testing out different layouts.

oauth_signup.go Outdated Show resolved Hide resolved
oauth_signup.go Outdated Show resolved Hide resolved
oauth_signup.go Outdated Show resolved Hide resolved
oauth_signup.go Outdated Show resolved Hide resolved
pages/signup-oauth.tmpl Outdated Show resolved Hide resolved
thebaer and others added 4 commits Jan 5, 2020
- Move them above local login form
- Restyle as side-by-side buttons

Ref T712
oauth.go Outdated Show resolved Hide resolved
oauth.go Outdated Show resolved Hide resolved
@thebaer
thebaer approved these changes Jan 8, 2020
Copy link
Member

thebaer left a comment

Looks and works great! Thanks, merging now.

@thebaer thebaer merged commit a2a9f60 into develop Jan 8, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the T712-oauth-registration-improvements branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.