Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename base_url to collection_url in Markdown API #233

Merged
merged 1 commit into from Jan 5, 2020
Merged

Conversation

@thebaer
Copy link
Member

thebaer commented Jan 5, 2020

This renames the base_url parameter to collection_url, to make it clear what the parameter is for (i.e. not the base URL of the instance, but of the collection itself).

Part of T519

Ref T519
@thebaer thebaer added this to the 0.12 milestone Jan 5, 2020
@thebaer thebaer requested a review from robjloranger Jan 5, 2020
Copy link
Member

robjloranger left a comment

Good call, I didn't test but I don't think that string needed to be initialized so should be good.

@thebaer

This comment has been minimized.

Copy link
Member Author

thebaer commented Jan 5, 2020

Cool, thanks for looking at it 👍

@thebaer thebaer merged commit 9be5340 into develop Jan 5, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the markdown-api-rename branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.