Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes imported post times #241

Open
wants to merge 2 commits into
base: develop
from
Open

fixes imported post times #241

wants to merge 2 commits into from

Conversation

@robjloranger
Copy link
Member

robjloranger commented Jan 14, 2020

changes the client side to round the unix time to avoid floats

alters the time to match the client time zone on the server side


  • I have signed the CLA
changes the client side to round the unix time to avoid floats

alters the time to match the client time zone on the server side
log.Error("form time zone offset not a valid integer: %v", err)
continue
}
dateTime = dateTime.Add(time.Minute * time.Duration(offset))

This comment has been minimized.

Copy link
@thebaer

thebaer Jan 14, 2020

Member

I think, design-wise, ideally we'd do all of this on the client-side, just like we do in templates/edit-meta.tmpl. That keeps the API clean, consistent, and the time logic all in one place, so it's always easier to debug.

@robjloranger robjloranger self-assigned this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.