Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require authenticated user for editor access #245

Merged
merged 1 commit into from Jan 20, 2020
Merged

Conversation

@thebaer
Copy link
Member

thebaer commented Jan 16, 2020

Previously, anyone could access the editor at /new (multi-user) or /me/new (single-user) even if they weren't logged in. They couldn't do much in that case (publishing would fail), but it could potentially cause some confusion.

Now, users will be sent to the login page, and then redirected back to the editor once successfully logged in.

Previously, anyone could access the editor even if they weren't logged
in. They couldn't do much in that case (publishing would fail), but it
could potentially cause some confusion.

Now, users will be sent to the login page, and then redirected back to
the editor once successfully logged in.
@thebaer thebaer added this to the 0.12 milestone Jan 16, 2020
Copy link
Member

robjloranger left a comment

Good idea

@thebaer
Copy link
Member Author

thebaer commented Jan 20, 2020

Thanks! Merging.

@thebaer thebaer merged commit fe26594 into develop Jan 20, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the fix-editor-open-access branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.