Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image extraction for social metadata #266

Merged
merged 2 commits into from Mar 1, 2020
Merged

Fix image extraction for social metadata #266

merged 2 commits into from Mar 1, 2020

Conversation

@thebaer
Copy link
Member

thebaer commented Feb 19, 2020

This fixes small issues with automatic image extraction for post metadata used by various social media platforms.

  • Extract images in draft posts
  • Fix image extraction for URLs with query strings on the end
Previously, we didn't extract images for draft posts. This fixes that.
@thebaer thebaer added this to the 0.12 milestone Feb 19, 2020
Previously, image extraction wouldn't catch images with a query string
(or anything else) appended. This fixes that by parsing extracted URLs
and only checking the path for what looks like an image file.
@thebaer
Copy link
Member Author

thebaer commented Mar 1, 2020

Pretty straightforward, and working in production so far. Merging now.

@thebaer thebaer merged commit fca864c into develop Mar 1, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the fix-social-images branch Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.