Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private instance cleanup #274

Merged
merged 3 commits into from Mar 27, 2020
Merged

Private instance cleanup #274

merged 3 commits into from Mar 27, 2020

Conversation

@thebaer
Copy link
Member

@thebaer thebaer commented Mar 2, 2020

This improves things a bit on private instances.

  • Hide Reader link in footer when unauthenticated on private instances.
    This isn't publicly visible, so as in the header, we now also hide this in the footer.
  • Show Log in page as landing on private instances, instead of normal landing page.
    Private instances are only meant for registered users, and are often closed or invite-only, making the current landing page kind of pointless (and potentially confusing). This remedies that by putting the login form first, while of course still linking to the signup page if an instance has open registrations.
thebaer added 3 commits Feb 12, 2020
(that is, hide the footer nav link when logged out)
This moves logic for determining whether or not to show a "Sign up" page
on /signup (i.e. because the `/` route shows another, non-signup page)
into the AppCfg.SignupPath() method. It also changes various signup
links to use this value.
@thebaer thebaer added this to the 0.12 milestone Mar 2, 2020
@cjeller1592
Copy link
Contributor

@cjeller1592 cjeller1592 commented Mar 3, 2020

Looks good! Really like having the "Reader" link removed in the footer and "Log in" as the default landing page. Definitely clears things up for private instances.

@thebaer
Copy link
Member Author

@thebaer thebaer commented Mar 27, 2020

Merging now!

@thebaer thebaer merged commit c340024 into develop Mar 27, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the private-instance-improvements branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.