Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ActivityPub mentions #282

Merged
merged 6 commits into from Mar 27, 2020
Merged

Clean up ActivityPub mentions #282

merged 6 commits into from Mar 27, 2020

Conversation

@thebaer
Copy link
Member

thebaer commented Mar 17, 2020

This includes some light cleanup around ActivityPub mentions (#195 / T627), from stability to schema design and logging improvements.

thebaer added 4 commits Mar 17, 2020
Previously, we might potentially return a nil activitystreams.Object,
which would crash the app. This fixes that.
This ensures handles are always stored without leading @ symbol.
This fixes log formatting and makes verbiage consistent & concise.
This makes the app less error-prone by avoiding a regexp.MustCompile()
call in the ActivityObject() method, saves CPU work, and reuses code.
@thebaer thebaer added this to the 0.12 milestone Mar 17, 2020
thebaer added 2 commits Mar 19, 2020
This alters the V6 migration to make the column NULLable. Anyone who has already run this migration will need to manually update their database.
@thebaer
Copy link
Member Author

thebaer commented Mar 24, 2020

This is ready for review now. Changes are currently live on Write.as.

@thebaer
Copy link
Member Author

thebaer commented Mar 27, 2020

For anyone running their instance from the develop branch: note the changes directly to the V6 migration here. You might need to manually update your database to reflect this (though the application should still work fine for now if you don't).

Merging now.

@thebaer thebaer merged commit 1d25b38 into develop Mar 27, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the patch-ap-mentions branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.