Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hashtags with numbers + letters #307

Merged
merged 1 commit into from May 7, 2020
Merged

Conversation

@thebaer
Copy link
Member

thebaer commented Apr 28, 2020

Previously, a hashtag like #100DaysToOffload wouldn't automatically turn into a clickable link -- all hashtags needed to start with an alphabetic character.

The saturday Markdown library we use now also parses out hashtags that begin with a number AND contain letters (but not numbers only). So this PR updates that dependency to bring the fix into WriteFreely.

Previously, a hashtag like #100DaysToOffload wouldn't automatically turn
into a clickable link. This fixes that by updating to the latest version
of the satuday library.
@thebaer thebaer added this to the 0.13 milestone Apr 28, 2020
@thebaer
Copy link
Member Author

thebaer commented May 7, 2020

Confirmed to be working well. Merging now.

@thebaer thebaer merged commit 037fc40 into develop May 7, 2020
@thebaer thebaer deleted the fix-numeric-alpha-hashtags branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.