Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login with generic oauth feature++ #317

Merged
merged 17 commits into from Aug 17, 2020
Merged

Conversation

@pascoual
Copy link
Contributor

@pascoual pascoual commented Jun 6, 2020

Create from @ketudb PR with @thebaer requested modifications about Connect / Disconnect buttons from Account Settings page

This aims to add a configurable, generic OAuth client module, so that it can be used with things like Keycloak etc, without needing a separate OAuth client configuration for every provider.

It adds the following ini settings under oauth.generic:

* `client_id`, `client_secret`, `CallbackProxy`, `CallbackProxyAPI` as usual

* `host`: The hostname/base URL for the oauth server

* `display_name`: The display name (defaults to "OAuth")

* `token_endpoint`, `inspect_endpoint`, `auth_endpoint` which will all be different depending on the oauth implementation.

* `allow_disconnect`: allow the user to disconnect his writefreely account from `oauth.generic` one

I've try to contact @ketudb but without success.

ketudb and others added 14 commits Mar 28, 2020
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Signed-off-by: prichier <pascoualito@gmail.com>
Add generic Oauth allow_logout option
@thebaer
Copy link
Member

@thebaer thebaer commented Jun 8, 2020

Thanks for taking over development on this, @pascoual! I'll review this soon.

@thebaer thebaer added this to the 0.13 milestone Jun 8, 2020
@ketudb
Copy link
Contributor

@ketudb ketudb commented Jun 9, 2020

Apologies for dropping out on this one - got extremely busy elsewhere. @pascoual thank you for jumping in here, and I'm sorry you were unable to reach me. I'll try to keep an eye on this PR - if you need anything mention me and I'll try to jump in 😄

@pascoual
Copy link
Contributor Author

@pascoual pascoual commented Jun 12, 2020

I need to add an option : disable_password_auth as we want to use WF with the SSO only.
@thebaer: I will make few more commits

@ketudb
Copy link
Contributor

@ketudb ketudb commented Jun 15, 2020

I need to add an option : disable_password_auth as we want to use WF with the SSO only.
@thebaer: I will make few more commits

This would be awesome, since it's exactly what I was trying to do. Thanks 😁

@pascoual
Copy link
Contributor Author

@pascoual pascoual commented Jun 16, 2020

Look at the last commit, it's done ;) !

@ketudb
Copy link
Contributor

@ketudb ketudb commented Jun 18, 2020

@pascoual that’s super awesome! thank you for taking over from me - this is not my coding language haha

i can’t wait to try it out

@c-cesar
Copy link

@c-cesar c-cesar commented Jul 26, 2020

This would enable to use WriteFreely on multiuser instances of YuNoHost, using one other app as oauth provider, like Nextcloud, without the need to implement LDAP.
And this is my current usercase.
Tank you so much.

@thebaer thebaer mentioned this pull request Aug 12, 2020
1 of 1 task complete
Copy link
Member

@thebaer thebaer left a comment

Thanks for your patience on my review. This looks great! Just one issue with the logic on the landing page, and then we'll need to resolve the conflicts introduced after merging #293.

pages/landing.tmpl Outdated Show resolved Hide resolved
@pascoual
Copy link
Contributor Author

@pascoual pascoual commented Aug 15, 2020

Got it, will fix it asap.

pascoual added 2 commits Aug 16, 2020
@pascoual pascoual requested a review from thebaer Aug 16, 2020
@pascoual
Copy link
Contributor Author

@pascoual pascoual commented Aug 16, 2020

I've also fix some merging issues from previous commit and find running WF in dev.

Copy link
Member

@thebaer thebaer left a comment

Thank you, @pascoual! Looks great -- merging now.

@thebaer thebaer merged commit dfa14c9 into writeas:develop Aug 17, 2020
@thebaer thebaer mentioned this pull request Aug 19, 2020
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.