Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preload fonts.css in base.tmpl #321

Open
wants to merge 1 commit into
base: master
from
Open

preload fonts.css in base.tmpl #321

wants to merge 1 commit into from

Conversation

@freddyb
Copy link

@freddyb freddyb commented Jun 10, 2020

Hi, this is an "explorational" pull request.
PageSpeed Insights tells me I could gain about 500ms on my blog, if I preloaded fonts.css.
Would you be open to preloading fonts like this?
From a read of the templates and the generated HTML, it seems you always end up at the resource at {{.Host}}/css/fonts.css. The JS bit in the bottom just controls when to enable it. Preloading with a <link> element shouldn't change that behavior.

Let me know if that looks acceptable, I'm happy to throw additional commits in this pull request branch for the other template files.

[Describe the pull request here...]


  • I have signed the CLA
Hi, this is an "explorational" pull request.
PageSpeed Insights tells me I could gain about 500ms on my blog, if I preloaded fonts.css.
Would you be open to preloading fonts like this?
From a read of the templates and the generated HTML, it seems you always end up at the resource at `{{.Host}}/css/fonts.css`. The JS bit in the bottom just controls when to enable it. Preloading with a `<link>` element shouldn't change that behavior.

Let me know if that looks acceptable, I'm happy to throw additional commits in this pull request branch for the other template files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.