New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dockerfile #34

Merged
merged 4 commits into from Nov 24, 2018

Conversation

Projects
None yet
4 participants
@koehn
Collaborator

koehn commented Nov 21, 2018

updated dockerfile to produce smaller image with minimum content/packages installed, and a few extra features (like not running as root); added .dockerignore

Updated Dockerfile to produce smaller image with minimum content and …
…a few extra features; added .dockerignore
Show resolved Hide resolved Dockerfile Outdated
@thebaer

This comment has been minimized.

Member

thebaer commented Nov 21, 2018

Thanks for the PR @koehn, and @jlelse for looking at this!

@koehn can you check out the agreement in the Contributing guide? If you're good with that, we can move forward. I'd also like to have @BenOvermyer take a look at these changes and see if they match with what he was planning on doing.

@koehn

This comment has been minimized.

Collaborator

koehn commented Nov 21, 2018

I’ve looked at the contributors guide and am good with it. Thanks!

@thebaer

This comment has been minimized.

Member

thebaer commented Nov 21, 2018

Great 👍 specifically, could you sign the agreement mentioned there?

@koehn

This comment has been minimized.

Collaborator

koehn commented Nov 21, 2018

Done.

@BenOvermyer

This comment has been minimized.

Collaborator

BenOvermyer commented Nov 24, 2018

These are exactly the changes I was going to make. Great job on this, @koehn !

@thebaer

This comment has been minimized.

Member

thebaer commented Nov 24, 2018

Awesome, I'll get this merged in now. Thanks everyone!

Could either of you update the README if anything needs to change there? Please feel free to commit directly to master for small updates like that.

@thebaer thebaer merged commit bdcacbc into writeas:master Nov 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@koehn

This comment has been minimized.

Collaborator

koehn commented Nov 24, 2018

I'll try to take on the README. I have a few questions:

  1. Is there (or can there be) a writeas Docker group, under which we can publish images e.g., writeas/writefreely:latest or writeas/writefreely:0.3.0? I can create one.
  2. Can publishing images become a part of the standard release process, alongside making the zip release?
  3. Any issues with me updating the docker-compose.yml file to use the Dockerfile and/or the published image?
@thebaer

This comment has been minimized.

Member

thebaer commented Nov 24, 2018

Great. To your questions:

  1. Sure, we can set that up. Would that be on something like Docker Hub? Wherever it is, I can create an account and give you access to do everything you need.
  2. Yep, happy to include that in the standard release process. Of course, automating this in any way we can will be best. Right now I run make release to build a new release, so that'd be the place to start.
  3. I don't have any problems with that if it makes setup easier / smoother, but anyone else can feel free to weigh in here.
@koehn

This comment has been minimized.

Collaborator

koehn commented Nov 24, 2018

We can also have another docker image for production use that uses the image. The main advantage being that you just need to docker-compose pull && docker-compose up -d to upgrade; there's no need to clone the git repo.

@koehn

This comment has been minimized.

Collaborator

koehn commented Nov 24, 2018

And yes, Docker Hub would be the place to set up the writeas organization. I can do it if you'd like, and add you as members and/or transfer ownership.

I added a PR for the make release script to build the Docker image. Once all that's in I can tackle the README.

@thebaer

This comment has been minimized.

Member

thebaer commented Nov 24, 2018

Yep, that's merged now. Official image is here: https://hub.docker.com/r/writeas/writefreely/

@koehn

This comment has been minimized.

Collaborator

koehn commented Nov 26, 2018

Not sure if my other message reached you: can you push the 0.4 docker image? Thanks!

@thebaer

This comment has been minimized.

Member

thebaer commented Nov 26, 2018

Yep, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment