Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation improvements #371

Merged
merged 7 commits into from Aug 31, 2020
Merged

Navigation improvements #371

merged 7 commits into from Aug 31, 2020

Conversation

@thebaer
Copy link
Member

@thebaer thebaer commented Aug 19, 2020

This PR brings some general quality-of-life improvements to blog navigation for multi- and single-user instances.

Persistent "New Post" button in the global navigation bar. Now it's easy to navigate back to the editor in a consistent way. Also, when on blog sub-sections like Customize and Stats, the button is contextual, i.e. clicking it will automatically select the current blog as the publishing target in the editor. Previously, this button was only enabled when an instance was configured with chorus = true.

Standard navigation across blog sub-sections. Now you can easily switch between customizing your blog, viewing stats, and viewing the blog itself with standard navigation. On single-user instances, these sections have been moved to the global navigation bar.

Single-user

Customize blog page

Before After
Screenshot from 2020-08-19 18-14-05 Screenshot from 2020-08-19 18-12-26

Multi-user

Customize blog page

Before After
Screenshot from 2020-08-19 18-17-05 Screenshot from 2020-08-19 18-16-24

Blogs page

Before After
Screenshot from 2020-08-19 18-15-04 Screenshot from 2020-08-19 18-15-59

  • I have signed the CLA
thebaer added 7 commits Aug 19, 2020
This makes it easier to navigate between different blog sections: Customize, Stats, View.
This uses the main navigation bar for the Customize and Stats pages, instead of the collection-navigation bar used for multi-user / multi-collection instances.
@thebaer thebaer added this to the 0.13 milestone Aug 19, 2020
@rkingett
Copy link

@rkingett rkingett commented Aug 20, 2020

Make sure the <NAV HTML elements are used to denote landmarks and otherwise. But this all looks good! I'm hoping accessibility is retained. I'm also hoping These HTML structural elements can be added, as well.

@thebaer
Copy link
Member Author

@thebaer thebaer commented Aug 31, 2020

Thanks for your input! This does put blog navigation into the more semantic nav element (instead of h4). For any structural issues, I think we'll address them as they come up while making other accessibility improvements.

Merging now!

@thebaer thebaer merged commit ce69117 into develop Aug 31, 2020
@thebaer thebaer deleted the design-update branch Aug 31, 2020
@rkingett
Copy link

@rkingett rkingett commented Sep 2, 2020

There is a little bit of excessive verbiage after navigating past the first banner landmark. The screen reader announces "Navigation landmark" 3 times.

Perhaps wrapping all the top elements into one HTML NAV would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.